uuid: add V6 #539
Open
uuid: add V6 #539
+82
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the extension added this (along with V7) recently php/pecl-networking-uuid@ea46ef6
|
Was that a different test suite? 
edit: Seems like it ran the test suite against an old version of extension (rather than the polyfill) on that CI thing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extension added support for V6 and V7 few months ago.
This PR contains implementation for V6. I might add V7 in another one, but I'd like to see some opinions about it's implementation first.
Option A:
Adaptation of Symfony\Component\Uid\UuidV7.
Option B:
Plain and simple timestamp + some random bits, just ignore the optional parts of the spec. Perhaps a better fit for the style of this library.